alee/golfgame
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

Tune knock-early thresholds and fix failing test suite

Browse Source 
Tighten should_knock_early() so AI no longer knocks with projected
scores of 12-14. New range: max_acceptable 5-9 (was 8-18), with
scaled knock_chance by score quality and an exception when all
opponents show 25+ visible points.

Fix 5 pre-existing test failures:
- test_event_replay: use game.current_player() instead of hardcoding
  "p1", since dealer logic makes p2 go first
- game.py: include current_player_idx in round_started event so state
  replay knows the correct starting player
- test_house_rules: rename test_rule_config → run_rule_config so
  pytest doesn't collect it as a test fixture

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
adlee-was-taken
2026-02-14 09:56:59 -05:00
parent 9bb9d1e397
commit 13ab5b9017
6 changed files with 1135 additions and 344 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
server/tests/test_event_replay.py
View File

@@ -125,8 +125,9 @@ class TestEventEmission:
game, collector = create_test_game(num_players=2)
game.start_game(num_decks=1, num_rounds=1, options=GameOptions(initial_flips=0))
current = game.current_player()
initial_count = len(collector.events)
card = game.draw_card("p1", "deck")
card = game.draw_card(current.id, "deck")
assert card is not None
new_events = collector.events[initial_count:]
@@ -134,7 +135,7 @@ class TestEventEmission:
assert len(draw_events) == 1
event = draw_events[0]
assert event.player_id == "p1"
assert event.player_id == current.id
assert event.data["source"] == "deck"
assert event.data["card"]["rank"] == card.rank.value
@@ -142,10 +143,12 @@ class TestEventEmission:
"""Swapping a card should emit card_swapped event."""
game, collector = create_test_game(num_players=2)
game.start_game(num_decks=1, num_rounds=1, options=GameOptions(initial_flips=0))
game.draw_card("p1", "deck")
current = game.current_player()
game.draw_card(current.id, "deck")
initial_count = len(collector.events)
old_card = game.swap_card("p1", 0)
old_card = game.swap_card(current.id, 0)
assert old_card is not None
new_events = collector.events[initial_count:]
@@ -153,24 +156,26 @@ class TestEventEmission:
assert len(swap_events) == 1
event = swap_events[0]
assert event.player_id == "p1"
assert event.player_id == current.id
assert event.data["position"] == 0
def test_discard_card_event(self):
"""Discarding drawn card should emit card_discarded event."""
game, collector = create_test_game(num_players=2)
game.start_game(num_decks=1, num_rounds=1, options=GameOptions(initial_flips=0))
drawn = game.draw_card("p1", "deck")
current = game.current_player()
drawn = game.draw_card(current.id, "deck")
initial_count = len(collector.events)
game.discard_drawn("p1")
game.discard_drawn(current.id)
new_events = collector.events[initial_count:]
discard_events = [e for e in new_events if e.event_type == EventType.CARD_DISCARDED]
assert len(discard_events) == 1
event = discard_events[0]
assert event.player_id == "p1"
assert event.player_id == current.id
assert event.data["card"]["rank"] == drawn.rank.value
@@ -383,13 +388,14 @@ class TestFullGameReplay:
game.start_game(num_decks=1, num_rounds=1, options=GameOptions(initial_flips=0))
# Do a swap
drawn = game.draw_card("p1", "deck")
old_card = game.get_player("p1").cards[0]
game.swap_card("p1", 0)
current = game.current_player()
drawn = game.draw_card(current.id, "deck")
old_card = game.get_player(current.id).cards[0]
game.swap_card(current.id, 0)
# Rebuild and verify
state = rebuild_state(collector.events)
rebuilt_player = state.get_player("p1")
rebuilt_player = state.get_player(current.id)
# The swapped card should be in the hand
assert rebuilt_player.cards[0].rank == drawn.rank.value