Animation fixes: - Fix held card positioning bug (was appearing at bottom of page) - Fix discard pile blank/white flash on turn transitions - Fix blank card at round end by skipping animations during round_over/game_over - Set card content before triggering flip animation to prevent flash - Center suit symbol on 10 cards Timing improvements: - Reduce post-discard delay from 700ms to 500ms - Reduce post-swap delay from 1800ms to 1000ms - Speed up swap flip animation from 1150ms to 550ms - Reduce CPU initial thinking delay from 150-250ms to 80-150ms - Pause now happens after swap completes (showing result) instead of before E2E test suite: - Add Playwright-based test bot that plays full games - State parser extracts game state from DOM for validation - AI brain ports decision logic for automated play - Freeze detector monitors for UI hangs - Visual validator checks CSS states - Full game, stress, and visual test specs Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
378 lines
13 KiB
JavaScript
378 lines
13 KiB
JavaScript
// AnimationQueue - Sequences card animations properly
|
|
// Ensures animations play in order without overlap
|
|
|
|
class AnimationQueue {
|
|
constructor(cardManager, getSlotRect, getLocationRect, playSound) {
|
|
this.cardManager = cardManager;
|
|
this.getSlotRect = getSlotRect; // Function to get slot position
|
|
this.getLocationRect = getLocationRect; // Function to get deck/discard position
|
|
this.playSound = playSound || (() => {}); // Sound callback
|
|
this.queue = [];
|
|
this.processing = false;
|
|
this.animationInProgress = false;
|
|
|
|
// Timing configuration (ms)
|
|
// Rhythm: action → settle → action → breathe
|
|
this.timing = {
|
|
flipDuration: 540, // Must match CSS .card-inner transition (0.54s)
|
|
moveDuration: 270,
|
|
pauseAfterFlip: 144, // Brief settle after flip before move
|
|
pauseAfterDiscard: 550, // Let discard land + pulse (400ms) + settle
|
|
pauseBeforeNewCard: 150, // Anticipation before new card moves in
|
|
pauseAfterSwapComplete: 400, // Breathing room after swap completes
|
|
pauseBetweenAnimations: 90
|
|
};
|
|
}
|
|
|
|
// Add movements to the queue and start processing
|
|
async enqueue(movements, onComplete) {
|
|
if (!movements || movements.length === 0) {
|
|
if (onComplete) onComplete();
|
|
return;
|
|
}
|
|
|
|
// Add completion callback to last movement
|
|
const movementsWithCallback = movements.map((m, i) => ({
|
|
...m,
|
|
onComplete: i === movements.length - 1 ? onComplete : null
|
|
}));
|
|
|
|
this.queue.push(...movementsWithCallback);
|
|
|
|
if (!this.processing) {
|
|
await this.processQueue();
|
|
}
|
|
}
|
|
|
|
// Process queued animations one at a time
|
|
async processQueue() {
|
|
if (this.processing) return;
|
|
this.processing = true;
|
|
this.animationInProgress = true;
|
|
|
|
while (this.queue.length > 0) {
|
|
const movement = this.queue.shift();
|
|
|
|
try {
|
|
await this.animate(movement);
|
|
} catch (e) {
|
|
console.error('Animation error:', e);
|
|
}
|
|
|
|
// Callback after last movement
|
|
if (movement.onComplete) {
|
|
movement.onComplete();
|
|
}
|
|
|
|
// Pause between animations
|
|
if (this.queue.length > 0) {
|
|
await this.delay(this.timing.pauseBetweenAnimations);
|
|
}
|
|
}
|
|
|
|
this.processing = false;
|
|
this.animationInProgress = false;
|
|
}
|
|
|
|
// Route to appropriate animation
|
|
async animate(movement) {
|
|
switch (movement.type) {
|
|
case 'flip':
|
|
await this.animateFlip(movement);
|
|
break;
|
|
case 'swap':
|
|
await this.animateSwap(movement);
|
|
break;
|
|
case 'discard':
|
|
await this.animateDiscard(movement);
|
|
break;
|
|
case 'draw-deck':
|
|
await this.animateDrawDeck(movement);
|
|
break;
|
|
case 'draw-discard':
|
|
await this.animateDrawDiscard(movement);
|
|
break;
|
|
}
|
|
}
|
|
|
|
// Animate a card flip
|
|
async animateFlip(movement) {
|
|
const { playerId, position, faceUp, card } = movement;
|
|
|
|
// Get slot position
|
|
const slotRect = this.getSlotRect(playerId, position);
|
|
if (!slotRect || slotRect.width === 0 || slotRect.height === 0) {
|
|
return;
|
|
}
|
|
|
|
// Create animation card at slot position
|
|
const animCard = this.createAnimCard();
|
|
this.cardManager.cardLayer.appendChild(animCard);
|
|
this.setCardPosition(animCard, slotRect);
|
|
|
|
const inner = animCard.querySelector('.card-inner');
|
|
const front = animCard.querySelector('.card-face-front');
|
|
|
|
// Set up what we're flipping to (front face)
|
|
this.setCardFront(front, card);
|
|
|
|
// Start face down (flipped = showing back)
|
|
inner.classList.add('flipped');
|
|
|
|
// Force a reflow to ensure the initial state is applied
|
|
animCard.offsetHeight;
|
|
|
|
// Animate the flip
|
|
this.playSound('flip');
|
|
await this.delay(50); // Brief pause before flip
|
|
|
|
// Remove flipped to trigger animation to front
|
|
inner.classList.remove('flipped');
|
|
|
|
await this.delay(this.timing.flipDuration);
|
|
await this.delay(this.timing.pauseAfterFlip);
|
|
|
|
// Clean up
|
|
animCard.remove();
|
|
}
|
|
|
|
// Animate a card swap (hand card to discard, drawn card to hand)
|
|
async animateSwap(movement) {
|
|
const { playerId, position, oldCard, newCard } = movement;
|
|
|
|
// Get positions
|
|
const slotRect = this.getSlotRect(playerId, position);
|
|
const discardRect = this.getLocationRect('discard');
|
|
const holdingRect = this.getLocationRect('holding');
|
|
|
|
if (!slotRect || !discardRect || slotRect.width === 0) {
|
|
return;
|
|
}
|
|
|
|
// Create a temporary card element for the animation
|
|
const animCard = this.createAnimCard();
|
|
this.cardManager.cardLayer.appendChild(animCard);
|
|
|
|
// Position at slot
|
|
this.setCardPosition(animCard, slotRect);
|
|
|
|
// Start face down (showing back)
|
|
const inner = animCard.querySelector('.card-inner');
|
|
const front = animCard.querySelector('.card-face-front');
|
|
inner.classList.add('flipped');
|
|
|
|
// Step 1: If card was face down, flip to reveal it
|
|
this.setCardFront(front, oldCard);
|
|
if (!oldCard.face_up) {
|
|
this.playSound('flip');
|
|
inner.classList.remove('flipped');
|
|
await this.delay(this.timing.flipDuration);
|
|
await this.delay(this.timing.pauseAfterFlip);
|
|
} else {
|
|
// Already face up, just show it immediately
|
|
inner.classList.remove('flipped');
|
|
}
|
|
|
|
// Step 2: Move card to discard pile
|
|
this.playSound('card');
|
|
animCard.classList.add('moving');
|
|
this.setCardPosition(animCard, discardRect);
|
|
await this.delay(this.timing.moveDuration);
|
|
animCard.classList.remove('moving');
|
|
|
|
// Let discard land and pulse settle
|
|
await this.delay(this.timing.pauseAfterDiscard);
|
|
|
|
// Step 3: Create second card for the new card coming into hand
|
|
const newAnimCard = this.createAnimCard();
|
|
this.cardManager.cardLayer.appendChild(newAnimCard);
|
|
|
|
// New card starts at holding/discard position
|
|
this.setCardPosition(newAnimCard, holdingRect || discardRect);
|
|
const newInner = newAnimCard.querySelector('.card-inner');
|
|
const newFront = newAnimCard.querySelector('.card-face-front');
|
|
|
|
// Show new card (it's face up from the drawn card)
|
|
this.setCardFront(newFront, newCard);
|
|
newInner.classList.remove('flipped');
|
|
|
|
// Brief anticipation before new card moves
|
|
await this.delay(this.timing.pauseBeforeNewCard);
|
|
|
|
// Step 4: Move new card to the hand slot
|
|
this.playSound('card');
|
|
newAnimCard.classList.add('moving');
|
|
this.setCardPosition(newAnimCard, slotRect);
|
|
await this.delay(this.timing.moveDuration);
|
|
newAnimCard.classList.remove('moving');
|
|
|
|
// Breathing room after swap completes
|
|
await this.delay(this.timing.pauseAfterSwapComplete);
|
|
animCard.remove();
|
|
newAnimCard.remove();
|
|
}
|
|
|
|
// Create a temporary animation card element
|
|
createAnimCard() {
|
|
const card = document.createElement('div');
|
|
card.className = 'real-card anim-card';
|
|
card.innerHTML = `
|
|
<div class="card-inner">
|
|
<div class="card-face card-face-front"></div>
|
|
<div class="card-face card-face-back"><span>?</span></div>
|
|
</div>
|
|
`;
|
|
return card;
|
|
}
|
|
|
|
// Set card position
|
|
setCardPosition(card, rect) {
|
|
card.style.left = `${rect.left}px`;
|
|
card.style.top = `${rect.top}px`;
|
|
card.style.width = `${rect.width}px`;
|
|
card.style.height = `${rect.height}px`;
|
|
}
|
|
|
|
// Set card front content
|
|
setCardFront(frontEl, cardData) {
|
|
frontEl.className = 'card-face card-face-front';
|
|
|
|
if (!cardData) return;
|
|
|
|
if (cardData.rank === '★') {
|
|
frontEl.classList.add('joker');
|
|
const jokerIcon = cardData.suit === 'hearts' ? '🐉' : '👹';
|
|
frontEl.innerHTML = `<span class="joker-icon">${jokerIcon}</span><span class="joker-label">Joker</span>`;
|
|
} else {
|
|
const isRed = cardData.suit === 'hearts' || cardData.suit === 'diamonds';
|
|
frontEl.classList.add(isRed ? 'red' : 'black');
|
|
const suitSymbol = this.getSuitSymbol(cardData.suit);
|
|
frontEl.innerHTML = `${cardData.rank}<br>${suitSymbol}`;
|
|
}
|
|
}
|
|
|
|
getSuitSymbol(suit) {
|
|
const symbols = { hearts: '♥', diamonds: '♦', clubs: '♣', spades: '♠' };
|
|
return symbols[suit] || '';
|
|
}
|
|
|
|
// Animate discarding a card (from hand to discard pile) - called for other players
|
|
async animateDiscard(movement) {
|
|
const { card, fromPlayerId, fromPosition } = movement;
|
|
|
|
// If no specific position, animate from opponent's area
|
|
const discardRect = this.getLocationRect('discard');
|
|
if (!discardRect) return;
|
|
|
|
let startRect;
|
|
|
|
if (fromPosition !== null && fromPosition !== undefined) {
|
|
startRect = this.getSlotRect(fromPlayerId, fromPosition);
|
|
}
|
|
|
|
// Fallback: use discard position offset upward
|
|
if (!startRect) {
|
|
startRect = {
|
|
left: discardRect.left,
|
|
top: discardRect.top - 80,
|
|
width: discardRect.width,
|
|
height: discardRect.height
|
|
};
|
|
}
|
|
|
|
// Create animation card
|
|
const animCard = this.createAnimCard();
|
|
this.cardManager.cardLayer.appendChild(animCard);
|
|
this.setCardPosition(animCard, startRect);
|
|
|
|
const inner = animCard.querySelector('.card-inner');
|
|
const front = animCard.querySelector('.card-face-front');
|
|
|
|
// Show the card that was discarded
|
|
this.setCardFront(front, card);
|
|
inner.classList.remove('flipped');
|
|
|
|
// Move to discard
|
|
this.playSound('card');
|
|
animCard.classList.add('moving');
|
|
this.setCardPosition(animCard, discardRect);
|
|
await this.delay(this.timing.moveDuration);
|
|
animCard.classList.remove('moving');
|
|
|
|
// Same timing as player swap - let discard land and pulse settle
|
|
await this.delay(this.timing.pauseAfterDiscard);
|
|
|
|
// Clean up
|
|
animCard.remove();
|
|
}
|
|
|
|
// Animate drawing from deck
|
|
async animateDrawDeck(movement) {
|
|
const { playerId } = movement;
|
|
|
|
const deckRect = this.getLocationRect('deck');
|
|
const holdingRect = this.getLocationRect('holding');
|
|
|
|
if (!deckRect || !holdingRect) return;
|
|
|
|
// Create animation card at deck position (face down)
|
|
const animCard = this.createAnimCard();
|
|
this.cardManager.cardLayer.appendChild(animCard);
|
|
this.setCardPosition(animCard, deckRect);
|
|
|
|
const inner = animCard.querySelector('.card-inner');
|
|
inner.classList.add('flipped'); // Show back
|
|
|
|
// Move to holding position
|
|
this.playSound('card');
|
|
animCard.classList.add('moving');
|
|
this.setCardPosition(animCard, holdingRect);
|
|
await this.delay(this.timing.moveDuration);
|
|
animCard.classList.remove('moving');
|
|
|
|
// Brief settle before state updates
|
|
await this.delay(this.timing.pauseBeforeNewCard);
|
|
|
|
// Clean up - renderGame will show the holding card state
|
|
animCard.remove();
|
|
}
|
|
|
|
// Animate drawing from discard
|
|
async animateDrawDiscard(movement) {
|
|
const { playerId } = movement;
|
|
|
|
// Discard to holding is mostly visual feedback
|
|
// The card "lifts" slightly
|
|
|
|
const discardRect = this.getLocationRect('discard');
|
|
const holdingRect = this.getLocationRect('holding');
|
|
|
|
if (!discardRect || !holdingRect) return;
|
|
|
|
// Just play sound - visual handled by CSS :holding state
|
|
this.playSound('card');
|
|
|
|
await this.delay(this.timing.moveDuration);
|
|
}
|
|
|
|
// Check if animations are currently playing
|
|
isAnimating() {
|
|
return this.animationInProgress;
|
|
}
|
|
|
|
// Clear the queue (for interruption)
|
|
clear() {
|
|
this.queue = [];
|
|
}
|
|
|
|
// Utility delay
|
|
delay(ms) {
|
|
return new Promise(resolve => setTimeout(resolve, ms));
|
|
}
|
|
}
|
|
|
|
// Export for use in app.js
|
|
if (typeof module !== 'undefined' && module.exports) {
|
|
module.exports = AnimationQueue;
|
|
}
|