alee/relicario
1
0
Fork 0
Code Issues Pull Requests 4 Actions Packages Projects Releases Wiki Activity

fix(ext/setup): lock verified handle on Step 5 error + early-return paths

Browse Source 
Mirrors Step 3b's discipline. Previously, if save_setup failed or addDevice
threw, state.verifiedHandle (the WASM session from Step 3b) would remain
in linear memory until tab close. Now lock+null on every exit path.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
adlee-was-taken
2026-04-27 19:12:22 -04:00
parent aa1ad99e6e
commit beff092818
1 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
extension/src/setup/setup.ts
View File

@@ -1142,7 +1142,14 @@ function attachStep5(): void {
}, },
); );
}); });
if (!saveOk) { render(); return; } if (!saveOk) {
if (state.verifiedHandle !== null) {
try { w.lock(state.verifiedHandle); } catch { /* best effort */ }
state.verifiedHandle = null;
}
render();
return;
}
// 3) Register device on the remote (read-modify-write devices.json). // 3) Register device on the remote (read-modify-write devices.json).
const hostUrl = state.hostType === 'github' ? 'https://api.github.com' : state.hostUrl; const hostUrl = state.hostType === 'github' ? 'https://api.github.com' : state.hostUrl;
@@ -1164,6 +1171,10 @@ function attachStep5(): void {
} catch (err: unknown) { } catch (err: unknown) {
console.error('[relicario setup] register device failed:', err); console.error('[relicario setup] register device failed:', err);
state.error = `Failed to register device: ${err instanceof Error ? err.message : String(err)}`; state.error = `Failed to register device: ${err instanceof Error ? err.message : String(err)}`;
if (state.verifiedHandle !== null) {
try { (await loadWasm()).lock(state.verifiedHandle); } catch { /* best effort */ }
state.verifiedHandle = null;
}
render(); render();
} }
}); });