alee/relicario
1
0
Fork 0
Code Issues Pull Requests 4 Actions Packages Projects Releases Wiki Activity

fix(core): correct off-by-one in imgsecret SOF bounds guard

Browse Source 
peek_jpeg_dimensions reads jpeg[i+8] as the last byte, so the guard
should be \`i + 8 >= jpeg.len()\`, not \`i + 9 >= jpeg.len()\`. The old
guard would reject a valid SOF marker ending exactly at len()-1.
Caught in Task 2 code-quality review.
This commit is contained in:
adlee-was-taken
2026-04-19 21:34:53 -04:00
parent 7853db061e
commit c8535e11f5
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
crates/relicario-core/src/imgsecret.rs
View File

@@ -139,7 +139,7 @@ fn peek_jpeg_dimensions(jpeg: &[u8]) -> Result<(u32, u32)> {
} // SOI / EOI } // SOI / EOI
0xC0..=0xC3 | 0xC5..=0xC7 | 0xC9..=0xCB | 0xCD..=0xCF => { 0xC0..=0xC3 | 0xC5..=0xC7 | 0xC9..=0xCB | 0xCD..=0xCF => {
// SOFn — height in [i+5..i+7], width in [i+7..i+9] // SOFn — height in [i+5..i+7], width in [i+7..i+9]
if i + 9 >= jpeg.len() { if i + 8 >= jpeg.len() {
return Err(RelicarioError::ImgSecret("truncated SOF marker".into())); return Err(RelicarioError::ImgSecret("truncated SOF marker".into()));
} }
let height = u16::from_be_bytes([jpeg[i + 5], jpeg[i + 6]]) as u32; let height = u16::from_be_bytes([jpeg[i + 5], jpeg[i + 6]]) as u32;