From 1bc36c21b21b91aefd2b32b1ce6ba878daba8188 Mon Sep 17 00:00:00 2001 From: "Aaron D. Lee" Date: Mon, 6 Jul 2026 15:42:43 -0400 Subject: [PATCH] fix(smoke): enable Plan A assertions (ASSERT_ENGINE_REPLY + ASSERT_ZERO_DROPS) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Plan A (PR #24, merged as 7e2ae6d) landed the TCP_NODELAY + TCP_QUICKACK-suppression + WS ping fixes that the smoke harness's ASSERT_ENGINE_REPLY + ASSERT_ZERO_DROPS flags gate on. The flags were left False during deploy-B's Task 6 (commit 4c62222) pending Plan A's integration. Plan A is now integrated in docs/deployment-topology-spec at 838ecdf, so the flags flip True — the smoke + smoke-reload CI jobs now have teeth. Signed-off-by: Aaron D. Lee --- deploy/smoke/allinone_smoke.py | 2 +- deploy/smoke/reload_during_call.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/deploy/smoke/allinone_smoke.py b/deploy/smoke/allinone_smoke.py index 2bd6b61..d7d3d08 100755 --- a/deploy/smoke/allinone_smoke.py +++ b/deploy/smoke/allinone_smoke.py @@ -307,7 +307,7 @@ def main() -> int: # cycle is the verification surface pre-A (image built + WS handshake # succeeds + frames flow through Caddy TLS) — that's what we assert until # Plan A merges, then enable the engine-reply fail() assertion. - ASSERT_ENGINE_REPLY = False # Set True once Plan A lands. + ASSERT_ENGINE_REPLY = True # Set True once Plan A lands. if received < 1: if ASSERT_ENGINE_REPLY: fail("expected at least one engine-originated text frame (mark/outbound)") diff --git a/deploy/smoke/reload_during_call.py b/deploy/smoke/reload_during_call.py index 6684e13..bf54eb2 100755 --- a/deploy/smoke/reload_during_call.py +++ b/deploy/smoke/reload_during_call.py @@ -121,7 +121,7 @@ def main() -> int: # containerized TLS — Plan A lands the hygiene that makes these assertions # meaningful (without NODELAY + pings, WS frames may coalesce / quiet WS # may die mid-reload for non-Plan-A reasons unrelated to stream_close_delay). - ASSERT_ZERO_DROPS = False # Set True once Plan A lands. + ASSERT_ZERO_DROPS = True # Set True once Plan A lands. if ws_dropped: if ASSERT_ZERO_DROPS: fail("WS dropped during caddy reload — stream_close_delay mitigation "