fix: address final-review items (status endpoint, docs, tests)
Follow-up to the holistic review of the PIN-unification branch: - /system/status now reads the real arm state from the arm_state_log table via get_current_arm_state, instead of returning a hardcoded 'DISARMED' stub. Without this, polling after the new async 202 arm/disarm flow was a UX dead-end — clients never saw the state change they just requested. DB read failures degrade gracefully. - Operator guide: correct the claim that 'vigilar config set-pin' populates recovery_passphrase_hash. It doesn't. recovery_passphrase _hash has no CLI helper today; it must be set manually. - Tests: add a fail-closed regression for verify_pin on malformed stored hashes, and a companion test confirming the deprecation warning stays silent on a fully migrated config. All address specific review comments on the branch; no scope creep. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit was merged in pull request #7.
This commit is contained in:
@@ -157,3 +157,30 @@ def test_deprecation_warning_for_arm_pin_hash(tmp_path, caplog):
|
||||
assert any("arm_pin_hash" in m and "deprecated" in m.lower() for m in messages), (
|
||||
f"expected deprecation warning mentioning arm_pin_hash, got: {messages}"
|
||||
)
|
||||
|
||||
|
||||
def test_no_deprecation_warning_when_security_pin_hash_set(tmp_path, caplog):
|
||||
"""No warning should fire if [security] pin_hash is populated,
|
||||
regardless of whether [system] arm_pin_hash is also still present.
|
||||
The warning is specifically for un-migrated configs."""
|
||||
import logging
|
||||
cfg_path = tmp_path / "migrated.toml"
|
||||
cfg_path.write_text(
|
||||
'[system]\n'
|
||||
'arm_pin_hash = "pbkdf2_sha256$legacy$value"\n'
|
||||
'\n'
|
||||
'[security]\n'
|
||||
'pin_hash = "pbkdf2_sha256$current$value"\n'
|
||||
)
|
||||
with caplog.at_level(logging.WARNING):
|
||||
from vigilar.config import load_config
|
||||
load_config(str(cfg_path))
|
||||
|
||||
deprecation_messages = [
|
||||
r.message for r in caplog.records
|
||||
if r.levelno >= logging.WARNING and "arm_pin_hash" in r.message
|
||||
]
|
||||
assert deprecation_messages == [], (
|
||||
f"deprecation warning should not fire on migrated configs, "
|
||||
f"got: {deprecation_messages}"
|
||||
)
|
||||
|
||||
Reference in New Issue
Block a user