alee/relicario
1
0
Fork 0
Code Issues Pull Requests 6 Actions Packages Projects Releases Wiki Activity

v0.8.1 Dev-B: org add/edit parity for Card/Key/Totp #10

Open
alee wants to merge 0 commits from feature/v0.8.1-dev-b-card-key-totp into main
pull from: feature/v0.8.1-dev-b-card-key-totp
merge into: alee:main
Conversation 0 Commits - Files Changed -
alee commented 2026-06-21 01:02:30 +00:00
Owner
Copy Link

Stream B of the v0.8.1 org item-type parity lift. Rebased on merged Dev-A (b09e0ce).

  • B1+B2: org add card/key/totp via shared item_build builders; --*-stdin secret flags; build_org_item drops tags (run_add sets them).
  • B3: org edit converted to interactive per-type editing via item_build edit helpers; Edit{query,totp_qr}; item-update trailer retained.
  • Tests: org_items 14/14, org_authz adapted; full relicario-cli suite green; clippy adds zero new warnings.
  • Skeleton kept additive for Dev-C (Document arm + run_edit file param slot in without a rewrite).

3-lens adversarial review (security/spec/test-adequacy) all PASS; minor coverage gaps closed.

Stream B of the v0.8.1 org item-type parity lift. Rebased on merged Dev-A (b09e0ce). - B1+B2: `org add card/key/totp` via shared item_build builders; --*-stdin secret flags; build_org_item drops tags (run_add sets them). - B3: `org edit` converted to interactive per-type editing via item_build edit helpers; Edit{query,totp_qr}; item-update trailer retained. - Tests: org_items 14/14, org_authz adapted; full relicario-cli suite green; clippy adds zero new warnings. - Skeleton kept additive for Dev-C (Document arm + run_edit file param slot in without a rewrite). 3-lens adversarial review (security/spec/test-adequacy) all PASS; minor coverage gaps closed.
alee added 5 commits 2026-06-21 01:02:33 +00:00
test(cli/org): failing Card/Key/Totp org add round-trips (B4, pre-A-integration) 07862b8d44 
Adds run_stdin + create_collection_and_grant fixture helpers and three
acceptance tests for org add card/key/totp. Red until B1/B2 wire the
subcommands (currently: unrecognized subcommand). Asserts org get masks
card number + key material without --show. Edit round-trips land with B3.
feat(cli/org): org add parity for Card/Key/Totp via shared builders 82feb49ab4
feat(cli/org): interactive per-type org edit via shared edit helpers 290bc4e2d0
test(cli/org): adapt grant-denial edit case to interactive org edit 04ad98973a 
B3 dropped the flat --username/--url/... flags from `org edit`, so the
ungranted-member denial test must drive the bare interactive form. The
ungranted member is now rejected at manifest lookup (filter_for_member +
resolve_org_query) before any prompt is read.
test(cli/org): grant enforcement + body/secret-stdin + key-edit coverage e76d7167d6 
Closes the minor coverage gaps from the final adversarial review:
- org add card/key/totp reject ungranted + unknown collections (pins the
  grant gate on the new write paths, which runs before any secret prompt)
- secure-note --body-stdin masks body; totp --secret-stdin round-trips
  (completes the --*-stdin matrix for the org surface)
- key-material edit accept-branch round-trip, verified via get --show
This branch is already included in the target branch. There is nothing to merge.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feature/v0.8.1-dev-b-card-key-totp:feature/v0.8.1-dev-b-card-key-totp
git checkout feature/v0.8.1-dev-b-card-key-totp
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
alee
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: alee/relicario#10
Delete Branch "feature/v0.8.1-dev-b-card-key-totp"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?