alee/vigilar
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: correct set-password docstring (scrypt, not bcrypt) #4

Merged
alee merged 1 commits from fix/audit-followups into main 2026-04-05 16:53:23 +00:00
Conversation 1 Commits 1 Files Changed 1 +1 -4
alee commented 2026-04-05 14:51:19 +00:00
Owner
Copy Link

The set_password_cmd docstring and inline comment claimed bcrypt / SHA-256, but the implementation actually uses scrypt via cryptography.hazmat.primitives.kdf.scrypt. Correct the docstring, drop the misleading comment, and remove the now-unused hashlib import.

No behavior change — comment/doc correction only. The function already called Scrypt(...).derive(...); only the surrounding prose lied.

Related honesty-pass follow-ups filed separately: #1, #2, #3.

The `set_password_cmd` docstring and inline comment claimed bcrypt / SHA-256, but the implementation actually uses scrypt via `cryptography.hazmat.primitives.kdf.scrypt`. Correct the docstring, drop the misleading comment, and remove the now-unused `hashlib` import. No behavior change — comment/doc correction only. The function already called `Scrypt(...).derive(...)`; only the surrounding prose lied. Related honesty-pass follow-ups filed separately: #1, #2, #3.
alee added 1 commit 2026-04-05 14:51:20 +00:00
fix: correct set-password docstring (scrypt, not bcrypt) 17bd403217 
The set_password_cmd docstring and inline comment claimed bcrypt /
SHA-256, but the implementation actually uses scrypt via
cryptography.hazmat.primitives.kdf.scrypt. Correct the docstring,
drop the misleading comment, and remove the now-unused hashlib import.

No behavior change.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
alee commented 2026-04-05 16:30:55 +00:00
Author
Owner
Copy Link

Simple docstring and comment correction.

Simple docstring and comment correction.
alee merged commit 17bd403217 into main 2026-04-05 16:53:23 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
alee
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: alee/vigilar#4
Delete Branch "fix/audit-followups"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?