alee/vigilar
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

scratch: code-review-tea smoke test (do not merge) #9

Closed
alee wants to merge 1 commits from scratch/code-review-tea-smoke into main
pull from: scratch/code-review-tea-smoke
merge into: alee:main
Conversation 1 Commits 1 Files Changed 1 +8
alee commented 2026-06-27 18:12:44 +00:00
Owner
Copy Link

Throwaway PR to verify the code-review-tea pipeline end-to-end. Safe to close.

Throwaway PR to verify the code-review-tea pipeline end-to-end. Safe to close.
alee added 1 commit 2026-06-27 18:14:18 +00:00
scratch: code-review-tea smoke test (do not merge) 4d814e8808
alee force-pushed scratch/code-review-tea-smoke from e5e6d6df0e to 4d814e8808 2026-06-27 18:14:18 +00:00 Compare
alee commented 2026-06-27 18:17:42 +00:00
Author
Owner
Copy Link

Code review

Found 2 issues:

  1. Assignment instead of comparison in if condition (bug: if state = \"armed\": uses single = (assignment) instead of ==; in Python this is a SyntaxError — assignment cannot appear in an if condition, so the module fails to parse/import)

vigilar/vigilar/_scratch_review.py Lines 5 to 7 in 4d814e8808
# BUG: assignment instead of comparison (==)
if state = "armed":
return True

  1. Missing type hints on public function (CLAUDE.md says "Type hints on all public functions")

vigilar/vigilar/_scratch_review.py Lines 3 to 7 in 4d814e8808
def is_armed(state):
# BUG: assignment instead of comparison (==)
if state = "armed":
return True

🤖 Generated with Claude Code

- If this code review was useful, please react with 👍. Otherwise, react with 👎.

### Code review Found 2 issues: 1. Assignment instead of comparison in `if` condition (bug: `if state = \"armed\":` uses single `=` (assignment) instead of `==`; in Python this is a SyntaxError — assignment cannot appear in an `if` condition, so the module fails to parse/import) https://git.adlee.work/alee/vigilar/src/commit/4d814e88081cb05997fccac830006077565cf02f/vigilar/_scratch_review.py#L5-L7 2. Missing type hints on public function (CLAUDE.md says "Type hints on all public functions") https://git.adlee.work/alee/vigilar/src/commit/4d814e88081cb05997fccac830006077565cf02f/vigilar/_scratch_review.py#L3-L7 🤖 Generated with [Claude Code](https://claude.ai/code) <sub>- If this code review was useful, please react with 👍. Otherwise, react with 👎.</sub>
alee closed this pull request 2026-06-27 18:19:08 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
alee
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: alee/vigilar#9
Delete Branch "scratch/code-review-tea-smoke"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?