alee/rutster
0
0
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects Releases Wiki Activity

fix(smoke): enable Plan A assertions (ASSERT_ENGINE_REPLY + ASSERT_ZERO_DROPS)

Browse Source 
Plan A (PR #24, merged as 7e2ae6d) landed the TCP_NODELAY +
TCP_QUICKACK-suppression + WS ping fixes that the smoke harness's
ASSERT_ENGINE_REPLY + ASSERT_ZERO_DROPS flags gate on. The flags
were left False during deploy-B's Task 6 (commit 4c62222) pending
Plan A's integration. Plan A is now integrated in docs/deployment-topology-spec
at 838ecdf, so the flags flip True — the smoke + smoke-reload CI jobs
now have teeth.

Signed-off-by: Aaron D. Lee <himself@adlee.work>
This commit is contained in:
A.D.Lee
2026-07-06 15:42:43 -04:00
parent 3aa9fa4e29
commit 1bc36c21b2
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
deploy/smoke/allinone_smoke.py
View File

@@ -307,7 +307,7 @@ def main() -> int:
# cycle is the verification surface pre-A (image built + WS handshake
# succeeds + frames flow through Caddy TLS) — that's what we assert until
# Plan A merges, then enable the engine-reply fail() assertion.
ASSERT_ENGINE_REPLY = False # Set True once Plan A lands.
ASSERT_ENGINE_REPLY = True # Set True once Plan A lands.
if received < 1:
if ASSERT_ENGINE_REPLY:
fail("expected at least one engine-originated text frame (mark/outbound)")

2
deploy/smoke/reload_during_call.py
View File

@@ -121,7 +121,7 @@ def main() -> int:
# containerized TLS — Plan A lands the hygiene that makes these assertions
# meaningful (without NODELAY + pings, WS frames may coalesce / quiet WS
# may die mid-reload for non-Plan-A reasons unrelated to stream_close_delay).
ASSERT_ZERO_DROPS = False # Set True once Plan A lands.
ASSERT_ZERO_DROPS = True # Set True once Plan A lands.
if ws_dropped:
if ASSERT_ZERO_DROPS:
fail("WS dropped during caddy reload — stream_close_delay mitigation "